hchaverri commented on code in PR #5897:
URL: https://github.com/apache/hadoop/pull/5897#discussion_r1278018944
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/token/delegation/AbstractDelegationTokenSecretManager.java:
##########
@@ -771,10 +771,14 @@ protected void logExpireTokens(
for (TokenIdent ident : expiredTokens) {
logExpireToken(ident);
LOG.info("Removing expired token " + formatTokenId(ident));
Review Comment:
I'm trying to follow the behavior of the other SecretManagers that extend
this class, where they log this line and later log an error if anything failed.
Some examples on `JHSDelegationTokenSecretManager`,
`RMDelegationTokenSecretManager` and `ZKDelegationTokenSecretManager`
I will add a bit more logging on the SQLDTSM to call out if/why the token
was not removed. Do you think this will be enough?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
