[ 
https://issues.apache.org/jira/browse/HADOOP-18820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17747595#comment-17747595
 ] 

ASF GitHub Bot commented on HADOOP-18820:
-----------------------------------------

steveloughran commented on PR #5872:
URL: https://github.com/apache/hadoop/pull/5872#issuecomment-1652156127

   current dependency setup
   ```
   [INFO] +- com.amazonaws:aws-java-sdk-core:jar:1.12.367:provided
   [INFO] |  +- commons-logging:commons-logging:jar:1.1.3:provided
   [INFO] |  +- software.amazon.ion:ion-java:jar:1.0.2:provided
   [INFO] |  +- 
com.fasterxml.jackson.dataformat:jackson-dataformat-cbor:jar:2.12.7:provided
   [INFO] |  \- joda-time:joda-time:jar:2.8.1:provided
   [INFO] +- software.amazon.awssdk:bundle:jar:2.19.12:compile
   [INFO] |  \- software.amazon.eventstream:eventstream:jar:1.0.1:compile
   ```
   sdk core stuff is being involved, which isn't needed at all.
   
   I'm pulling in the changes of #5739 to align dependencies, then make sure 
more are stripped. 
   
   This gives
   ```
   [INFO] +- com.amazonaws:aws-java-sdk-core:jar:1.12.367:provided
   [INFO] +- software.amazon.awssdk:bundle:jar:2.19.12:compile
   [INFO] +- software.amazon.awssdk.crt:aws-crt:jar:0.21.0:test
   ```
   @ahmarsuhail what do we do about the crt library? is it in bundle.jar? is it 
something to tag as provided and document?




> AWS SDK v2: make the v1 bridging support optional
> -------------------------------------------------
>
>                 Key: HADOOP-18820
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18820
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.4.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>
> The AWS SDK v2 code includes the v1 sdk core for plugin support of
> * existing credential providers
> * delegation token binding
> I propose we break #2 and rely on those who have implemented to to upgrade. 
> apart from all the needless changes the v2 SDK did to the api (why?) this is 
> fairly straighforward
> for #1: fix through reflection, retaining a v1 sdk dependency at test time so 
> we can verify that the binder works. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to