anujmodi2021 commented on code in PR #5881:
URL: https://github.com/apache/hadoop/pull/5881#discussion_r1273348707


##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/utils/TracingContext.java:
##########
@@ -217,10 +220,13 @@ private String getPrimaryRequestIdForHeader(final Boolean 
isRetry) {
   }
 
   private String addFailureReasons(final String header,
-      final String previousFailure) {
+      final String previousFailure, String retryPolicyAbbreviation) {
     if (previousFailure == null) {
       return header;
     }
+    if (CONNECTION_TIMEOUT_ABBREVIATION.equals(previousFailure) && 
retryPolicyAbbreviation != null) {

Review Comment:
   Nothing I can think of from the file system flow. There were a few places in 
test I guess..
   Anyways its good to have a check instead of hitting NPE.
   What say?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to