hfutatzhanghb commented on code in PR #5809:
URL: https://github.com/apache/hadoop/pull/5809#discussion_r1257219563
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java:
##########
@@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() {
public List<FsVolumeImpl> getVolumeList() {
return null;
}
+
+ @Override
+ public void setLastDirScannerFinishTime(long time) {}
Review Comment:
@xinglin , sir. I do not know why exacltly, I think the SimulatedFSDataset
is just for simplifing test. if we make both behave the same way, there is no
need to have class SimulatedFSDataset.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/datanode/extdataset/ExternalDatasetImpl.java:
##########
@@ -477,4 +482,7 @@ public MountVolumeMap getMountVolumeMap() {
public List<FsVolumeImpl> getVolumeList() {
return null;
}
+
+ @Override
+ public void setLastDirScannerFinishTime(long time) {}
Review Comment:
@xinglin , sir. I do not know why exacltly, I think the SimulatedFSDataset
is just for simplifing test. if we make both behave the same way, there is no
need to have class SimulatedFSDataset.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
