hfutatzhanghb commented on code in PR #5778:
URL: https://github.com/apache/hadoop/pull/5778#discussion_r1241488678
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockPlacementPolicyDefault.java:
##########
@@ -1236,11 +1245,17 @@ public DatanodeStorageInfo chooseReplicaToDelete(
minSpace = free;
minSpaceStorage = storage;
}
+ if (considerLoad2chooseReplicaDeleting && nodeLoad < minLoad) {
+ minLoad = nodeLoad;
+ minLoadStorage = storage;
+ }
}
final DatanodeStorageInfo storage;
if (oldestHeartbeatStorage != null) {
storage = oldestHeartbeatStorage;
+ } else if (minLoadStorage != null) {
Review Comment:
@Hexiaoqiao Sir, thanks for your reply. If we open the configuration
mentioned in this PR, we should consider load first and we keep running
Balancer background. And I also have thinked some improvements about the
changes:
1. should we consider load use `load.factor` like
`dfs.namenode.redundancy.considerLoad.factor`?
2. should we add another configuration to judge the difference between two
storage's remaining in an acceptable range?
Looking forward to your reply~ Thanks sir.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
