mehakmeet commented on code in PR #5763:
URL: https://github.com/apache/hadoop/pull/5763#discussion_r1239616737
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/ITestAssumeRole.java:
##########
@@ -448,7 +448,7 @@ public void testReadOnlyOperations() throws Throwable {
policy(
statement(false, S3_ALL_BUCKETS, S3_PATH_WRITE_OPERATIONS),
STATEMENT_ALL_S3,
- STATEMENT_ALLOW_SSE_KMS_READ));
+ STATEMENT_ALLOW_SSE_KMS_RW));
Review Comment:
nit: We can maybe rename this constant to `STATEMENT_ALLOW_KMS_RW` since kms
can be used server-side or client-side and both would apply the same policy.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
