[ 
https://issues.apache.org/jira/browse/HADOOP-18778?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17736343#comment-17736343
 ] 

ASF GitHub Bot commented on HADOOP-18778:
-----------------------------------------

mehakmeet commented on PR #5763:
URL: https://github.com/apache/hadoop/pull/5763#issuecomment-1603647229

   Had the same patch in my local repo 😄. Thanks for taking this up 
@ahmarsuhail. Yes, there was a gap in testing with Assume role + CSE enabled 
which led to this test being missed. Since there are quite a few toggleable 
features the testing coverage does get some blind spots. Not sure if there's 
already one, but a documented list of features that can cover the whole test 
suite could be helpful like CSE, Assume Roles, Access point ARN, SSE etc.
   In my testing of CSE + Assume role I believe the only tests failed for me 
were the Assume role one and `ITestPartialRenamesDeletes.java`, however the 
failure was due to some Access denied which could be due to a gap in my assume 
role policy maybe, was on my list to investigate that.
   I'll checkout your patch and run it through my configs once and let you 
know. 




> Test failures with CSE enabled
> ------------------------------
>
>                 Key: HADOOP-18778
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18778
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>            Reporter: Ahmar Suhail
>            Assignee: Ahmar Suhail
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 3.3.9
>
>
> The following tests fail when run hadoop-aws suite is run with CSE enabled:
>  
> {{ITestS3APrefetchingInputStream.testRandomReadLargeFile}}
> {{ITestS3APrefetchingInputStream.testReadLargeFileFully}}
> {{ITestS3APrefetchingInputStream.testReadLargeFileFullyLazySeek}}
> {{ITestS3ARequesterPays.testRequesterPaysOptionSuccess}}
> {{ITestAssumeRole.testReadOnlyOperations }}
> {{ITestPartialRenamesDeletes.testRenameParentPathNotWriteable}}
> {{ITestPartialRenamesDeletes.testRenameParentPathNotWriteable}}
> {{ITestS3GuardTool.testLandsatBucketRequireUnencrypted}}
>  
> Most of these are because they're using landsat data which is not encrypted, 
> so trying to read with a CSE will fail. These tests should be skipped if 
> using CSE.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to