steveloughran commented on PR #5421:
URL: https://github.com/apache/hadoop/pull/5421#issuecomment-1547909482
so you want me to merge this as is?
oh, here's my list for the next iteration
----
```
*
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/auth/AwsCredentialListProvider.java
L184 access denied exception. add test for this?
AWSClientConfig
TODO: Don't think you can set a socket factory for the netty client.
cloudstore: add the new paths
import software.amazon.awssdk.http.apache.ApacheHttpClient;
import
software.amazon.awssdk.thirdparty.org.apache.http.conn.ssl.SSLConnectionSocketFactory;
oftware.amazon.awssdk.services.s3.model.HeadBucketResponse;
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/HeaderProcessing.java
+add test for getHeaders(/) to see what comes back
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ABucketExistence.java
L128 use explicit region constant rather than inline string
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AConfiguration.java
L552: use intercept()
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AEndpointRegion.java
L75: just throw the exception again
L87, L90, use constants
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AAWSCredentialsProvider.java
L44 move o.a.h. imports into "real" hadoop block; include the sets one too
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/TestS3AProxy.java
is new ssl.proxy setting consistent with what this pr does
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/auth/delegation/ITestSessionDelegationInFileystem.java
L335 TODO open, getObjectMetadata("/")
? maybe just raise the exception, as getFileStatus() will create a fake
entry here, and nothing else should be calling root explicitly
+cut
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/InconsistentS3ClientFactory.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
