[
https://issues.apache.org/jira/browse/HADOOP-18684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17707098#comment-17707098
]
ASF GitHub Bot commented on HADOOP-18684:
-----------------------------------------
cnauroth commented on code in PR #5521:
URL: https://github.com/apache/hadoop/pull/5521#discussion_r1153974579
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/InternalConstants.java:
##########
@@ -182,4 +182,9 @@ private InternalConstants() {
Collections.unmodifiableSet(
new HashSet<>(Arrays.asList(Constants.FS_S3A_CREATE_PERFORMANCE)));
+ /**
+ * The default scheme for S3A filesystem.
+ */
+ public static final String S3A_SCHEME_DEFAULT = "s3a";
Review Comment:
Instead of defining a new constant, can you reuse
`org.apache.hadoop.fs.s3a.Constans#FS_S3A`?
> Fix S3A filesystem such that the scheme matches the URI scheme
> --------------------------------------------------------------
>
> Key: HADOOP-18684
> URL: https://issues.apache.org/jira/browse/HADOOP-18684
> Project: Hadoop Common
> Issue Type: Improvement
> Affects Versions: 3.3.5
> Reporter: Harshit Gupta
> Priority: Major
> Labels: pull-request-available
>
> Certain codepaths use the FileContext API's to perform FS based operations
> such as yarn log aggregations. While trying to reuse the S3A connector for
> GCS based workloads the yarn log aggregation was not happening. Upon further
> investigation it was observed that FileContext API have hardcoded URI scheme
> checks that need to disabled/updated to make S3A compatible with non AWS
> stores.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
