saxenapranav commented on PR #5299:
URL: https://github.com/apache/hadoop/pull/5299#issuecomment-1449328120
Hi @steveloughran,
Thanks for the review. I have made following changes:
1. All enums have got their own class. The implementations are extending an
abstract-class "RetryReasonCategory " which exposes following package-protected
methods. These methods are not public. There is a public method
"captureAndGetAbbreviation" in the abstract class which call these methods.:
1. canCapture: returns if the server-response error can be categorized by
the implementation.
2. getAbbreviation: returns the abbreviation corresponding to the server
response error.
2. RetryReason has a list of implementations of RetryReasonCategory which is
sorted by their significance.
3. Test-class "TestRetryReason" has been added to test each subclass of
RetryReasonCategory implementation.
Requesting you to please review the revision.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
