slfan1989 commented on code in PR #5434:
URL: https://github.com/apache/hadoop/pull/5434#discussion_r1120204689
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java:
##########
@@ -1238,36 +1240,44 @@ public void testAllDatanodesReconfig()
when(reconfigurationUtil.parseChangedProperties(any(Configuration.class),
any(Configuration.class))).thenReturn(changes);
- assertEquals(0, admin.startReconfiguration("datanode", "livenodes"));
+ int result = admin.startReconfiguration("datanode", "livenodes");
+ Assertions.assertThat(result).isEqualTo(0);
final List<String> outsForStartReconf = new ArrayList<>();
final List<String> errsForStartReconf = new ArrayList<>();
reconfigurationOutErrFormatter("startReconfiguration", "datanode",
"livenodes", outsForStartReconf, errsForStartReconf);
- assertEquals(3, outsForStartReconf.size());
- assertEquals(0, errsForStartReconf.size());
- assertTrue(outsForStartReconf.get(0).startsWith("Started reconfiguration
task on node"));
- assertTrue(outsForStartReconf.get(1).startsWith("Started reconfiguration
task on node"));
- assertEquals("Starting of reconfiguration task successful on 2 nodes,
failed on 0 nodes.",
- outsForStartReconf.get(2));
+ String started = "Started reconfiguration task on node";
+ String starting =
+ "Starting of reconfiguration task successful on 2 nodes, failed on 0
nodes.";
+ Assertions.assertThat(outsForStartReconf.size()).isEqualTo(3);
Review Comment:
Thanks for your suggestion, I will improve the code!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
