[
https://issues.apache.org/jira/browse/HADOOP-18635?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17690345#comment-17690345
]
ASF GitHub Bot commented on HADOOP-18635:
-----------------------------------------
steveloughran commented on code in PR #5402:
URL: https://github.com/apache/hadoop/pull/5402#discussion_r1109612693
##########
hadoop-tools/hadoop-distcp/src/test/java/org/apache/hadoop/tools/TestDistCpSystem.java:
##########
@@ -452,7 +454,12 @@ public void testDistcpLargeFile() throws Exception {
};
LOG.info("_____ running distcp: " + args[0] + " " + args[1]);
- ToolRunner.run(conf, new DistCp(), args);
+ DistCp distcpTool = new DistCp();
+ ToolRunner.run(conf, distcpTool, args);
+ final long bytesCopied = NumberUtils.toLong(distcpTool.getConf().
+ get(CONF_LABEL_DISTCP_TOTAL_BYTES_COPIED), 0);
+ assertEquals("Bytes copied by distcp tool should match source file length",
Review Comment:
assert args are the wrong way round for the generated error messages.
> Expose distcp counters to user via config parameter and distcp contants
> -----------------------------------------------------------------------
>
> Key: HADOOP-18635
> URL: https://issues.apache.org/jira/browse/HADOOP-18635
> Project: Hadoop Common
> Issue Type: Improvement
> Components: tools/distcp
> Affects Versions: 3.4.0
> Reporter: Amit Saonerkar
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
>
> Currently users or application such as Hive cannot access directly the distcp
> counters such as total number of bytes copied by distcp operation.
> This Jira is to enable this functionality in distcp tool.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
