simbadzina commented on code in PR #5298:
URL: https://github.com/apache/hadoop/pull/5298#discussion_r1104810291
##########
hadoop-hdfs-project/hadoop-hdfs-rbf/src/main/java/org/apache/hadoop/hdfs/server/federation/router/RouterRpcClient.java:
##########
@@ -1702,10 +1724,12 @@ private List<? extends FederationNamenodeContext>
getOrderedNamenodes(String nsI
boolean isObserverRead) throws IOException {
final List<? extends FederationNamenodeContext> namenodes;
- if (RouterStateIdContext.getClientStateIdFromCurrentCall(nsId) >
Long.MIN_VALUE) {
+ if (isNamespaceStateIdFresh(nsId)
+ && (RouterStateIdContext.getClientStateIdFromCurrentCall(nsId) >
Long.MIN_VALUE)) {
namenodes = namenodeResolver.getNamenodesForNameserviceId(nsId,
isObserverRead);
} else {
namenodes = namenodeResolver.getNamenodesForNameserviceId(nsId, false);
+ refreshTimeOfLastCallToActiveNameNode(nsId);
Review Comment:
You are right, we should update when isObserverRead is false. Let me clean
up the logic in that function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
