[
https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17684808#comment-17684808
]
ASF GitHub Bot commented on HADOOP-18206:
-----------------------------------------
virajjasani commented on PR #5315:
URL: https://github.com/apache/hadoop/pull/5315#issuecomment-1419383687
> just noticed that http-components pulls in commons logging so things which
depend on that still need to export it. question then becomes: do we want to
explicitly manage the dependency there?
>
> ```
> [info] | | +-org.apache.hadoop:hadoop-azure:3.3.5
> [info] | | | +-com.microsoft.azure:azure-storage:7.0.1
> [info] | | | | +-com.microsoft.azure:azure-keyvault-core:1.0.0
> [info] | | | | +-org.slf4j:slf4j-api:1.7.12 (evicted by: 2.0.6)
> [info] | | | | +-org.slf4j:slf4j-api:2.0.6
> [info] | | | |
> [info] | | | +-org.apache.hadoop.thirdparty:hadoop-shaded-guava:1.1.1
> [info] | | | +-org.apache.httpcomponents:httpclient:4.5.13 (evicted by:
4.5.14)
> [info] | | | +-org.apache.httpcomponents:httpclient:4.5.14
> [info] | | | | +-commons-codec:commons-codec:1.11 (evicted by: 1.15)
> [info] | | | | +-commons-codec:commons-codec:1.15
> [info] | | | | +-commons-logging:commons-logging:1.2
> [info] | | | | +-org.apache.httpcomponents:httpcore:4.4.16
> ```
Good question, I actually removed them in the initial iteration, however
while running some testing, it failed. Because many dependencies still need
commons-logging and hence we see bunch of CNFE for few dependencies.
I had to keep the changes and let dependencies pull in commons-logging as
they would like. The only thing we can change is, remove commons-logging
references from our codebase. Which we are doing with this PR.
> Cleanup the commons-logging references in the code base
> -------------------------------------------------------
>
> Key: HADOOP-18206
> URL: https://issues.apache.org/jira/browse/HADOOP-18206
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
>
> Should always use slf4j
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]