susheel-gupta commented on code in PR #5320:
URL: https://github.com/apache/hadoop/pull/5320#discussion_r1097183443
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-resourcemanager/src/main/java/org/apache/hadoop/yarn/server/resourcemanager/scheduler/capacity/CapacitySchedulerConfiguration.java:
##########
@@ -723,6 +727,17 @@ public <S extends SchedulableEntity> OrderingPolicy<S>
getAppOrderingPolicy(
return orderingPolicy;
}
+ public void setOrderingPolicy(String queue,
+ String appOrderingPolicy, String postfix, boolean value) {
+ setBoolean(getQueuePrefix(queue) +
+ "ordering-policy" + DOT + appOrderingPolicy + DOT + postfix, value);
+ }
+
+ public boolean getOrderingPolicy(String queue, String appOrderingPolicy,
String postfix) {
+ return getBoolean(getQueuePrefix(queue) +
+ "ordering-policy" + DOT + appOrderingPolicy + DOT + postfix, false);
+ }
Review Comment:
Yes, the naming is misleading(for now I have removed this getter and
setter), if we don't introduce a getter and setters for this then the purpose
of this the jira seems to be incomplete. So what do you suggest, do we go
without this getter and setter for the above property.?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
