steveloughran commented on code in PR #5162:
URL: https://github.com/apache/hadoop/pull/5162#discussion_r1093579485
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Client.java:
##########
@@ -1182,7 +1183,12 @@ public void sendRpcRequest(final Call call)
final ResponseBuffer buf = new ResponseBuffer();
header.writeDelimitedTo(buf);
RpcWritable.wrap(call.rpcRequest).writeTo(buf);
- rpcRequestQueue.put(Pair.of(call, buf));
+ synchronized (sendRpcRequestLock) {
Review Comment:
markClosed doesn't use the same lock, so i don't see this stopping a race
condition between
this submission and the markClosed set+purge queue;
better: move rpcRequestQueue.put(Pair.of(call, buf)); into a new method, and
make synchronized
```java
private sychronized put(pair) {
if (!shouldCloseConnection.get()) {
rpcRequestQueue.put(pair);
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
