[
https://issues.apache.org/jira/browse/HADOOP-18206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17677928#comment-17677928
]
Viraj Jasani edited comment on HADOOP-18206 at 1/17/23 7:54 PM:
----------------------------------------------------------------
There are some places where we still can't directly use slf4j logger. For
instance, FSNamesystem has audit logger and async appenders are added to the
logger. Here, we will still have to continue using "org.apache.log4j.Logger"
because appenders are added programmatically. But yes, that doesn't stop us
from removing all commons-logging references.
[~zhangduo] [[email protected]] This work would take some more time, but just
wanted to check with you on this. Are you fine with me raising one PR that
removes commons-logging from all modules or we want to take it up one module at
a time? I am currently cleaning up commons-logging references in hdfs modules.
I am fine either ways, can raise PR as per your suggestions.
was (Author: vjasani):
There are some places where we still can't directly use slf4j logger. For
instance, FSNamesystem has audit logger and async appenders are added to the
logger. Here, we will still have to continue using "org.apache.log4j.Logger"
because appenders are added programmatically.
[~zhangduo] [[email protected]] This work would take some more time, but just
wanted to check with you on this. Are you fine with me raising one PR that
removes commons-logging from all modules or we want to take it up one module at
a time? I am currently cleaning up commons-logging references in hdfs modules.
I am fine either ways, can raise PR as per your suggestions.
> Cleanup the commons-logging references in the code base
> -------------------------------------------------------
>
> Key: HADOOP-18206
> URL: https://issues.apache.org/jira/browse/HADOOP-18206
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Duo Zhang
> Assignee: Viraj Jasani
> Priority: Major
>
> Should always use slf4j
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
