tomscut commented on code in PR #5296:
URL: https://github.com/apache/hadoop/pull/5296#discussion_r1070294888
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java:
##########
@@ -1017,12 +1017,19 @@ static private void ensurePositiveInt(int val, String
key) {
*
* @param newVal - Must be a positive non-zero integer.
*/
- public void setMaxReplicationStreams(int newVal) {
- ensurePositiveInt(newVal,
- DFSConfigKeys.DFS_NAMENODE_REPLICATION_MAX_STREAMS_KEY);
+ @VisibleForTesting
+ public void setMaxReplicationStreams(int newVal, boolean ensurePositiveInt) {
+ if (ensurePositiveInt) {
Review Comment:
Why do we need to add this judgment?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
