sauraank opened a new pull request, #5274:
URL: https://github.com/apache/hadoop/pull/5274
<!--
Thanks for sending a pull request!
1. If this is your first time, please read our contributor guidelines:
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
2. Make sure your PR title starts with JIRA issue id, e.g.,
'HADOOP-17799. Your PR title ...'.
-->
### Description of PR
Logged the errors at the info level with just the message. Added the stack
at the Debug level. Not made any changes where error stack was not present and
had only the message and parameters at Warn/INFO level.
Also, removed the case of multiple logging in case of prefetch. Moved the
log one method above ReadBlock() (which was common for sync read thread and
async prefetch thread) and logged it at ERROR level for the case of read.
### How was this patch tested?
Logging levels of Error/info was tested locally by throwing errors in case
of both cases of async prefetch and sync get calls for read separately. Then
the unit test of ITestS3APrefetchingInputStream integration test (
testReadLargeFileFully) was used.
Finally done the integration test by `mvn -Dparallel-tests clean verify` in
the `eu-west-1` region.
Following is the result of the tests -
[INFO] Results:
[INFO]
[WARNING] Tests run: 1154, Failures: 0, Errors: 0, Skipped: 182
[INFO]
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:integration-test
(sequential-integration-tests) @ hadoop-aws ---
[INFO]
[INFO] --- maven-jar-plugin:2.5:jar (default-jar) @ hadoop-aws ---
[INFO] Building jar:
/home/ec2-user/hadoop/hadoop-tools/hadoop-aws/target/hadoop-aws-3.4.0-SNAPSHOT.jar
[INFO] Results:
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 124, Failures: 0, Errors: 0, Skipped: 84
[INFO]
[INFO]
[INFO] --- maven-enforcer-plugin:3.0.0:enforce (depcheck) @ hadoop-aws ---
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:verify (default-integration-test)
@ hadoop-aws ---
[INFO]
[INFO] --- maven-failsafe-plugin:3.0.0-M1:verify
(sequential-integration-tests) @ hadoop-aws ---
[INFO]
------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO]
------------------------------------------------------------------------
### For code changes:
- [ ] Does the title or this PR starts with the corresponding JIRA issue id
(e.g. 'HADOOP-17799. Your PR title ...')?
- [ ] Object storage: have the integration tests been executed and the
endpoint declared according to the connector-specific documentation?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the `LICENSE`, `LICENSE-binary`,
`NOTICE-binary` files?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
