hfutatzhanghb commented on PR #5262: URL: https://github.com/apache/hadoop/pull/5262#issuecomment-1368616110
> Thanx @hfutatzhanghb for the fix. Had a quick look I was able to reproduce the issue. But I don't think the fix is correct. It is logging the path wrt the router not wrt the namespace. say, /mount -> ns0. /dir is a mount entry you create /mount/fiel1 on the namenode of ns0, with your fix it would be logging /mount/file1, which in actual should be /dir/file1 > > You need to extend a UT as well for the change. > > Quick Suggestion for the fix, create a new invokeSingle method with the current signature, which calls your new invokeSingle with some default value, in order to avoid changes at places you don't have src Thanx @ayushtkn for your careful review. I was totally agree with your opinions。Yes，the src is not the dst path, but we can use the src to lookup real dst path in mount table. Here, we can not execute `this.subclusterResolver.getMountPoints(path);`, because the statement is time-consuming. It violates the purpose that we use previous block. I am looking forward to your reply and do the next steps. thanks again~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
