[
https://issues.apache.org/jira/browse/HADOOP-18576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17648176#comment-17648176
]
ASF GitHub Bot commented on HADOOP-18576:
-----------------------------------------
ayushtkn commented on code in PR #5226:
URL: https://github.com/apache/hadoop/pull/5226#discussion_r1049966999
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/codec/package-info.java:
##########
@@ -7,22 +7,25 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
+ *
+ * Erasure codec framework.
*/
/**
* Erasure codec framework.
*/
Review Comment:
this looks duplicate
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/rawcoder/package-info.java:
##########
@@ -7,13 +7,26 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
+ *
+ *
+ * Raw erasure coders.
+ *
+ * Raw erasure coder is part of erasure codec framework, where erasure coder is
+ * used to encode/decode a group of blocks (BlockGroup) according to the codec
+ * specific BlockGroup layout and logic. An erasure coder extracts chunks of
+ * data from the blocks and can employ various low level raw erasure coders to
+ * perform encoding/decoding against the chunks.
+ *
+ * To distinguish from erasure coder, here raw erasure coder is used to mean
the
+ * low level constructs, since it only takes care of the math calculation with
+ * a group of byte buffers.
*/
/**
Review Comment:
ok again, the same thing is below & why are we having it as part of licence
header?
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/io/erasurecode/coder/package-info.java:
##########
@@ -7,22 +7,25 @@
* "License"); you may not use this file except in compliance
* with the License. You may obtain a copy of the License at
*
- * http://www.apache.org/licenses/LICENSE-2.0
+ * http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
+ *
+ * Erasure coders framework.
*/
/**
* Erasure coders framework.
*/
Review Comment:
dupe
> javadoc 11 failing on @InterfaceAudience imports into
> hadoop-common/package-info
> --------------------------------------------------------------------------------
>
> Key: HADOOP-18576
> URL: https://issues.apache.org/jira/browse/HADOOP-18576
> Project: Hadoop Common
> Issue Type: Bug
> Components: build, common
> Affects Versions: 3.4.0
> Reporter: Steve Loughran
> Priority: Major
> Labels: pull-request-available
>
> yetus is failing javadoc builds with import issues on package-info.java files
> related to @InterfaceAudience/stability annotations
> We need to change how they are imported to fix this. Other modules have the
> same issue
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
