[ 
https://issues.apache.org/jira/browse/HADOOP-18183?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17647113#comment-17647113
 ] 

ASF GitHub Bot commented on HADOOP-18183:
-----------------------------------------

steveloughran commented on PR #5218:
URL: https://github.com/apache/hadoop/pull/5218#issuecomment-1351408553

   build was happy locally; test s3 london @ scale, and verified in logs that 
things worked
   ```
   183c9826b45486e485693808f38e2c4071004bf5dfd4c3ab210f0a21a4235ef8 
stevel-london [14/Dec/2022:12:59:35 +0000] 109.157.193.147 
arn:aws:iam::152813717728:user/stevel-dev 446CNGJCGD6DCZ4D REST.GET.OBJECT 
fork-0007/test/testReadSingleByteAcrossReadahead-sequential "GET 
/fork-0007/test/testReadSingleByteAcrossReadahead-sequential?versionId=uWXlWeVE5kCrTG.TRmC4gNekp5yWrELr
 HTTP/1.1" 206 - 2048 2048 28 14 
"https://audit.example.org/hadoop/1/op_open/be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029/?op=op_open&p1=fork-0007/test/testReadSingleByteAcrossReadahead-sequential&pr=stevel&ps=d12bd202-8831-4faf-965e-f3d7f23c3782&rg=0-2047&id=be0d9c4a-964e-423d-b22b-7fa5b56db268-00000029&t0=53&fs=be0d9c4a-964e-423d-b22b-7fa5b56db268&t1=53&ts=1671022775232";
 
   
   here rg=0-2047; a single byte was read in a stream with sequential read and 
readahead.
   
   I am happy with this and doing the merge, as it is a yetus issue and have 
just done the testing locally.
   




> s3a audit logs to publish range start/end of GET requests in audit header
> -------------------------------------------------------------------------
>
>                 Key: HADOOP-18183
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18183
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: fs/s3
>    Affects Versions: 3.3.2
>            Reporter: Steve Loughran
>            Assignee: Ankit Saurabh
>            Priority: Minor
>              Labels: pull-request-available
>
> we don't get the range of ranged get requests in s3 server logs, because the 
> AWS s3 log doesn't record that information. we can see it's a partial get 
> from the 206 response, but the length of data retrieved is lost.
> LoggingAuditor.beforeExecution() would need to recognise a ranged GET and 
> determine the extra key-val pairs for range start and end (rs & re?)
> we might need to modify {{HttpReferrerAuditHeader.buildHttpReferrer()}} to 
> take a map of <string, string> so it can dynamically create a header for each 
> request; currently that is not in there.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to