[ 
https://issues.apache.org/jira/browse/HADOOP-18563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Oleksandr Shevchenko updated HADOOP-18563:
------------------------------------------
    Description: 
[https://github.com/apache/hadoop/blob/branch-3.3.5/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java#L254]
{code:java}
// seconds until we give up trying to establish a connection to s3
  public static final String ESTABLISH_TIMEOUT =
      "fs.s3a.connection.establish.timeout";
  public static final int DEFAULT_ESTABLISH_TIMEOUT = 50000;

  // seconds until we give up on a connection to s3
  public static final String SOCKET_TIMEOUT = "fs.s3a.connection.timeout";
  public static final int DEFAULT_SOCKET_TIMEOUT = 200000;{code}
 
{code:java}
public static void initConnectionSettings(Configuration conf,
      ClientConfiguration awsConf) throws IOException {
    awsConf.setMaxConnections(intOption(conf, MAXIMUM_CONNECTIONS,
        DEFAULT_MAXIMUM_CONNECTIONS, 1));
    initProtocolSettings(conf, awsConf);
    awsConf.setMaxErrorRetry(intOption(conf, MAX_ERROR_RETRIES,
        DEFAULT_MAX_ERROR_RETRIES, 0));
    awsConf.setConnectionTimeout(intOption(conf, ESTABLISH_TIMEOUT,
        DEFAULT_ESTABLISH_TIMEOUT, 0));
    awsConf.setSocketTimeout(intOption(conf, SOCKET_TIMEOUT,
        DEFAULT_SOCKET_TIMEOUT, 0));
    int sockSendBuffer = intOption(conf, SOCKET_SEND_BUFFER,
{code}
AWS SDK S3 client actually consumes timeout in milliseconds
[https://github.com/aws/aws-sdk-java/blob/1.11.600/aws-java-sdk-core/src/main/java/com/amazonaws/ClientConfiguration.java#L185]

  was:
[https://github.com/apache/hadoop/blob/branch-3.3.5/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java#L254]
{code:java}
// seconds until we give up trying to establish a connection to s3
  public static final String ESTABLISH_TIMEOUT =
      "fs.s3a.connection.establish.timeout";
  public static final int DEFAULT_ESTABLISH_TIMEOUT = 50000;

  // seconds until we give up on a connection to s3
  public static final String SOCKET_TIMEOUT = "fs.s3a.connection.timeout";
  public static final int DEFAULT_SOCKET_TIMEOUT = 200000;{code}
AWS SDK S3 client actually consumes timeout in milliseconds
https://github.com/aws/aws-sdk-java/blob/1.11.600/aws-java-sdk-core/src/main/java/com/amazonaws/ClientConfiguration.java#L185


> Misleading AWS SDK S3 timeout configuration comment
> ---------------------------------------------------
>
>                 Key: HADOOP-18563
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18563
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 3.3.4
>            Reporter: Oleksandr Shevchenko
>            Assignee: Oleksandr Shevchenko
>            Priority: Trivial
>              Labels: pull-request-available
>
> [https://github.com/apache/hadoop/blob/branch-3.3.5/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/Constants.java#L254]
> {code:java}
> // seconds until we give up trying to establish a connection to s3
>   public static final String ESTABLISH_TIMEOUT =
>       "fs.s3a.connection.establish.timeout";
>   public static final int DEFAULT_ESTABLISH_TIMEOUT = 50000;
>   // seconds until we give up on a connection to s3
>   public static final String SOCKET_TIMEOUT = "fs.s3a.connection.timeout";
>   public static final int DEFAULT_SOCKET_TIMEOUT = 200000;{code}
>  
> {code:java}
> public static void initConnectionSettings(Configuration conf,
>       ClientConfiguration awsConf) throws IOException {
>     awsConf.setMaxConnections(intOption(conf, MAXIMUM_CONNECTIONS,
>         DEFAULT_MAXIMUM_CONNECTIONS, 1));
>     initProtocolSettings(conf, awsConf);
>     awsConf.setMaxErrorRetry(intOption(conf, MAX_ERROR_RETRIES,
>         DEFAULT_MAX_ERROR_RETRIES, 0));
>     awsConf.setConnectionTimeout(intOption(conf, ESTABLISH_TIMEOUT,
>         DEFAULT_ESTABLISH_TIMEOUT, 0));
>     awsConf.setSocketTimeout(intOption(conf, SOCKET_TIMEOUT,
>         DEFAULT_SOCKET_TIMEOUT, 0));
>     int sockSendBuffer = intOption(conf, SOCKET_SEND_BUFFER,
> {code}
> AWS SDK S3 client actually consumes timeout in milliseconds
> [https://github.com/aws/aws-sdk-java/blob/1.11.600/aws-java-sdk-core/src/main/java/com/amazonaws/ClientConfiguration.java#L185]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to