slfan1989 commented on code in PR #5169:
URL: https://github.com/apache/hadoop/pull/5169#discussion_r1038738974
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-common/src/test/java/org/apache/hadoop/yarn/server/federation/store/impl/TestSQLFederationStateStore.java:
##########
@@ -558,38 +562,134 @@ public void
testDeleteReservationHomeSubClusterAbnormalSituation() throws Except
() -> stateStore.deleteReservationHomeSubCluster(delRequest));
}
- @Test(expected = NotImplementedException.class)
+ @Test
public void testStoreNewMasterKey() throws Exception {
super.testStoreNewMasterKey();
}
- @Test(expected = NotImplementedException.class)
+ @Test
public void testGetMasterKeyByDelegationKey() throws YarnException,
IOException {
super.testGetMasterKeyByDelegationKey();
}
- @Test(expected = NotImplementedException.class)
+ @Test
public void testRemoveStoredMasterKey() throws YarnException, IOException {
super.testRemoveStoredMasterKey();
}
- @Test(expected = NotImplementedException.class)
+ @Test
public void testStoreNewToken() throws IOException, YarnException {
- super.testStoreNewToken();
Review Comment:
In this part, the test of the super class can cover the subclass, I will
modify this part of the code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
