sreeb-msft opened a new pull request, #5136:
URL: https://github.com/apache/hadoop/pull/5136

   <!--
     Thanks for sending a pull request!
       1. If this is your first time, please read our contributor guidelines: 
https://cwiki.apache.org/confluence/display/HADOOP/How+To+Contribute
       2. Make sure your PR title starts with JIRA issue id, e.g., 
'HADOOP-17799. Your PR title ...'.
   -->
   
   This PR parses SAS Tokens and removes the unwanted prefix of '?' from them, 
if present. 
   
   At present, SAS Tokens generated from the Azure Portal may or may not 
contain a '?' as a prefix. SAS Tokens that contain the '?' prefix will lead to 
an error in the driver due to a clash of query parameters. This leads to 
customers having to manually remove the '?' prefix before passing the SAS 
Tokens.
   
   After receiving the SAS Token from the provider (customer implementation of 
the SASTokenProvider interface in the driver code), The code checks for whether 
any ? prefix is present or not. If yes, it is removed before further usage of 
the token. This way, users would not have to manually remove the prefix before 
passing it on as a configuration. 
   
   #### Test Code added: 
   An additional test case has been added to the existing integration test 
class for SAS (ITestAzureBlobFileSystemDelegationSAS) - testSASQuesMarkPrefix. 
This method sets the SAS Token Provider to forcefully send a SAS Token with a ? 
mark prefix and then tests filesystem creation with this. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to