ZanderXu commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1293280962
Yeah, either fixe value or scale value look fine to me. If you want to limit the total cache memory, you need to consider multiple namespace case. As you said, the warn log may be ignored, so you need to take some measures to prevent OOM, such as failure to initialize one namespace if currently cache memory is big enough. So for me, the current logic is enough, and the project admin needs to set a reasonable value according to the number of namespace and the total heap size of journalNode if she/he want to enable this feature. Declare again, my idea does not block this PR. If anyone thinks this modification is necessary, I will review it carefully later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
