tomscut commented on PR #4209: URL: https://github.com/apache/hadoop/pull/4209#issuecomment-1291347727
> @tomscut Thanks for involving me. In my case, I think this PR is unnecessary. But we can print some warning logs to prompt the admin if the set memory is too large, such as more than 90% of the heap size. > > But, if anyone thinks this modification is necessary, I will review it carefully later. Thanks @ZanderXu for the review. There are already waring logs, but they are easy to ignore. Because there is no connection between memory and cache size, it's easy to miss when updating configuration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
