cosmind-db commented on code in PR #4907:
URL: https://github.com/apache/hadoop/pull/4907#discussion_r975028970
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsRestOperation.java:
##########
@@ -317,7 +321,8 @@ private boolean executeHttpOperation(final int retryCount,
return false;
} finally {
- AbfsClientThrottlingIntercept.updateMetrics(operationType,
httpOperation);
+ AbfsClientThrottlingIntercept instance =
AbfsClientThrottlingInterceptFactory.getInstance(accountName,
isAutoThrottlingEnabled, isSingletonEnabled);
+ instance.updateMetrics(operationType, httpOperation);
Review Comment:
if autothrottling is disabled , `AbfsClientThrottlingIntercept.getInstance`
will return null (see `AbfsClientThrottlingInterceptFactory.java` L58). That
in turn will cause a NPE here and above at L286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
