[
https://issues.apache.org/jira/browse/HADOOP-16769?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17605138#comment-17605138
]
ASF GitHub Bot commented on HADOOP-16769:
-----------------------------------------
ashutoshcipher commented on code in PR #4842:
URL: https://github.com/apache/hadoop/pull/4842#discussion_r971585276
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalDirAllocator.java:
##########
@@ -532,4 +533,19 @@ public void testGetLocalPathForWriteForInvalidPaths()
throws Exception {
}
}
-}
+ /**
+ * Test to check the LocalDirAllocation for the less space HADOOP-16769.
+ *
+ * @throws Exception
+ */
+ @Test(timeout = 30000)
+ public void testGetLocalPathForWriteForLessSpace() throws Exception {
+ String dir0 = buildBufferDir(ROOT, 0);
+ String dir1 = buildBufferDir(ROOT, 1);
+ conf.set(CONTEXT, dir0 + "," + dir1);
+ LambdaTestUtils.intercept(DiskErrorException.class,
+ String.format("Could not find any valid local directory for %s with
requested size %s",
+ "p1/x", Long.MAX_VALUE - 1), "Expect a DiskErrorException.",
+ () -> dirAllocator.getLocalPathForWrite("p1/x", Long.MAX_VALUE - 1,
conf));
+ }
+}
Review Comment:
Ack, will make this change
> LocalDirAllocator to provide diagnostics when file creation fails
> -----------------------------------------------------------------
>
> Key: HADOOP-16769
> URL: https://issues.apache.org/jira/browse/HADOOP-16769
> Project: Hadoop Common
> Issue Type: Improvement
> Components: util
> Reporter: Ramesh Kumar Thangarajan
> Assignee: Ashutosh Gupta
> Priority: Minor
> Labels: pull-request-available
> Attachments: HADOOP-16769.1.patch, HADOOP-16769.3.patch,
> HADOOP-16769.4.patch, HADOOP-16769.5.patch, HADOOP-16769.6.patch,
> HADOOP-16769.7.patch, HADOOP-16769.8.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Log details of requested size and available capacity when file creation is
> not successuful
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
