goiri commented on code in PR #4779:
URL: https://github.com/apache/hadoop/pull/4779#discussion_r971428466
##########
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-app/src/test/java/org/apache/hadoop/mapreduce/v2/app/launcher/TestContainerLauncherImpl.java:
##########
@@ -283,8 +283,24 @@ public void testOutOfOrder() throws Exception {
ut.handle(mockLaunchEvent);
ut.waitForPoolToIdle();
-
- verify(mockCM,
never()).startContainers(any(StartContainersRequest.class));
+
+ verify(mockCM).startContainers(any(StartContainersRequest.class));
+
+ LOG.info("inserting cleanup event");
+ ContainerLauncherEvent mockCleanupEvent2 =
Review Comment:
Another nit, now the line char limit is 100 characters; we can make these
lines into one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
