steveloughran commented on code in PR #4730:
URL: https://github.com/apache/hadoop/pull/4730#discussion_r946072098
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -997,13 +997,17 @@ protected RequestFactory createRequestFactory() {
String storageClassConf = getConf()
.getTrimmed(STORAGE_CLASS, "")
.toUpperCase(Locale.US);
- StorageClass storageClass;
- try {
- storageClass = StorageClass.fromValue(storageClassConf);
- } catch (IllegalArgumentException e) {
- LOG.warn("Unknown storage class property {}: {}; falling back to default
storage class",
- STORAGE_CLASS, storageClassConf);
- storageClass = null;
+ StorageClass storageClass = null;
+ if (!storageClassConf.isEmpty()) {
+ try {
+ storageClass = StorageClass.fromValue(storageClassConf);
+ } catch (IllegalArgumentException e) {
+ LOG.warn("Unknown storage class property {}: {}; falling back to
default storage class",
+ STORAGE_CLASS, storageClassConf);
+ }
+ } else {
+ LOG.info("Empty storage class property {}; falling back to default
storage class",
Review Comment:
yes, debug only, apart from some special cases where there's a risk of
incompatibility across versions (dir marker policy). even there i think it is
time to retire it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
