steveloughran commented on code in PR #4679:
URL: https://github.com/apache/hadoop/pull/4679#discussion_r936465070
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/DelegationTokenRenewer.java:
##########
@@ -256,9 +256,9 @@ public <T extends FileSystem & Renewable> void
removeRenewAction(
try {
action.cancel();
} catch (InterruptedException ie) {
- LOG.error("Interrupted while canceling token for " + fs.getUri()
+ LOG.error("Interrupted while canceling token for {} filesystem." +
fs.getUri()
Review Comment:
needs to move the fs.geturi to a param, not string concat
##########
hadoop-common-project/hadoop-registry/src/main/java/org/apache/hadoop/registry/server/services/RegistryAdminService.java:
##########
@@ -224,7 +224,7 @@ protected void serviceStart() throws Exception {
bindingDiagnosticDetails(),
dumpRegistryRobustly(true));
- LOG.error(" Failure {}", e, e);
+ LOG.error(" Failure {}", e.getMessage(), e);
Review Comment:
-1. to this change
L227 is valid; it calls e.toString on demand and handles any errors raised.
the second e forms the stack trace.
*e.getMessage() is null on some exceptions, like NPE*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
