huaxiangsun commented on PR #4608: URL: https://github.com/apache/hadoop/pull/4608#issuecomment-1203263503
Thanks @steveloughran for all the helps. I pushed a new patch, which I hope addresses your comments. 1. Undo the changes in FileSystem.java, code is duplicated in S3AFileSystem. 2. Incorporated some of your changes in [HADOOP-13611](https://issues.apache.org/jira/browse/HADOOP-13611) 3. Added a new s3a integration test case for deleteOnExit. I have run all integration test under hadoop-aws. Here are the results. <div id="breadcrumbs" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(0, 0, 0); font-family: Times; font-size: medium; font-variant-ligatures: normal; orphans: 2; widows: 2; text-decoration-thickness: initial;"><div class="xleft"><span id="publishDate">Last Published: 2022-08-02</span> | <span id="projectVersion">Version: 3.4.0-SNAPSHOT</span></div><div class="xright"></div><div class="clear"><hr></div></div><div id="leftColumn" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(0, 0, 0); font-f amily: Times; font-size: medium; font-variant-ligatures: normal; orphans: 2; widows: 2; text-decoration-thickness: initial;"><div id="navcolumn"><a href="http://maven.apache.org/"; title="Built by Maven" class="poweredBy" style="color: var(--accent-color) !important; text-decoration: underline !important; -apple-color-filter: none;"></a></div></div><div id="bodyColumn" style="font-style: normal; font-variant-caps: normal; font-weight: normal; letter-spacing: normal; text-align: start; text-indent: 0px; text-transform: none; white-space: normal; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; text-decoration: none; color: rgb(0, 0, 0); font-family: Times; font-size: medium; font-variant-ligatures: normal; orphans: 2; widows: 2; text-decoration-thickness: initial;"><div id="contentBox"><section><h2><a name="Failsafe_Report" style="color: rgb(158, 75, 47); text-decoration: underline !important;"></a>Failsafe Report</h2></section><section><h2><a name="S ummary" style="color: rgb(158, 75, 47); text-decoration: underline !important;"></a>Summary</h2><a name="Summary" style="color: rgb(158, 75, 47); text-decoration: underline !important;"></a><p>[<a style="color: rgb(158, 75, 47); text-decoration: underline !important;">Summary</a>] [<a style="color: rgb(158, 75, 47); text-decoration: underline !important;">Package List</a>] [<a style="color: rgb(158, 75, 47); text-decoration: underline !important;">Test Cases</a>]</p><br> Tests | Errors | Failures | Skipped | Success Rate | Time -- | -- | -- | -- | -- | -- 1253 | 7 | 0 | 270 | 77.893% | 3,301.515 </section></div></div> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
