goiri commented on code in PR #4650:
URL: https://github.com/apache/hadoop/pull/4650#discussion_r933374728
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-nodemanager/src/main/java/org/apache/hadoop/yarn/server/nodemanager/amrmproxy/AMRMProxyService.java:
##########
@@ -867,19 +878,20 @@ public static class RequestInterceptorChainWrapper {
/**
* Initializes the wrapper with the specified parameters.
*
- * @param rootInterceptor the root request intercepter
+ * @param rootInterceptor the root request interceptor
* @param applicationAttemptId attempt id
*/
+ @SuppressWarnings("checkstyle:HiddenField")
Review Comment:
I think the checkstyle warning is legit.
The code is easier to read if the variable name is different.
Adding the "this" makes it correct but it hides the high-level issue.
I would rename the arguments to make clear that they are different than the
fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
