steveloughran commented on code in PR #4636:
URL: https://github.com/apache/hadoop/pull/4636#discussion_r931322342
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractVectoredReadTest.java:
##########
@@ -60,9 +60,9 @@ public abstract class AbstractContractVectoredReadTest
extends AbstractFSContrac
protected static final byte[] DATASET =
ContractTestUtils.dataset(DATASET_LEN, 'a', 32);
protected static final String VECTORED_READ_FILE_NAME = "vectored_file.txt";
- private final IntFunction<ByteBuffer> allocate;
+ protected final IntFunction<ByteBuffer> allocate;
Review Comment:
keep private and add getters
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AInstrumentation.java:
##########
@@ -835,6 +839,10 @@ private InputStreamStatistics(
StreamStatisticNames.STREAM_READ_SEEK_BYTES_DISCARDED,
StreamStatisticNames.STREAM_READ_SEEK_BYTES_SKIPPED,
StreamStatisticNames.STREAM_READ_TOTAL_BYTES,
+ StreamStatisticNames.STREAM_READ_VECTORED_OPERATIONS,
Review Comment:
can you keep in alphabetical order
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
