steveloughran commented on code in PR #4642:
URL: https://github.com/apache/hadoop/pull/4642#discussion_r931039984
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:
##########
@@ -30,6 +30,8 @@
import java.util.concurrent.ExecutorService;
import com.amazonaws.services.s3.model.DeleteObjectsRequest;
+
+import org.apache.hadoop.fs.store.audit.AuditSpan;
Review Comment:
this should go into the main o.a.h imports. it getting in here because the
Preconditions class is where guava is. cherrypicking is a lot easier if imports
avoid this area
##########
hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/scale/ILoadTestS3ABulkDeleteThrottling.java:
##########
@@ -144,26 +146,24 @@ public ILoadTestS3ABulkDeleteThrottling(
@Override
protected Configuration createScaleConfiguration() {
Configuration conf = super.createScaleConfiguration();
- S3ATestUtils.disableFilesystemCaching(conf);
- return conf;
- }
- @Override
- public void setup() throws Exception {
- final Configuration conf = getConf();
S3ATestUtils.removeBaseAndBucketOverrides(conf,
EXPERIMENTAL_AWS_INTERNAL_THROTTLING,
BULK_DELETE_PAGE_SIZE,
USER_AGENT_PREFIX);
Review Comment:
should add ENABLE_MULTI_DELETE here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
