[
https://issues.apache.org/jira/browse/HADOOP-18180?focusedWorklogId=786539&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-786539
]
ASF GitHub Bot logged work on HADOOP-18180:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 30/Jun/22 12:17
Start Date: 30/Jun/22 12:17
Worklog Time Spent: 10m
Work Description: dannycjones commented on code in PR #4520:
URL: https://github.com/apache/hadoop/pull/4520#discussion_r910945935
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java:
##########
@@ -1573,7 +1560,7 @@ protected S3AReadOpContext createReadContext(
statistics,
statisticsContext,
fileStatus,
- futurePool,
+ unboundedThreadPool,
Review Comment:
Why not the `boundedThreadPool` originally wrapped by `futurePool`?
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AReadOpContext.java:
##########
@@ -18,10 +18,11 @@
package org.apache.hadoop.fs.s3a;
+import java.util.concurrent.ExecutorService;
Review Comment:
There's a `javax.annotation.Nullable` import below Apache. Can you bring it
up to this import?
rel:
https://github.com/steveloughran/formality/blob/master/styleguide/styleguide.md#imports
Issue Time Tracking
-------------------
Worklog Id: (was: 786539)
Time Spent: 8h (was: 7h 50m)
> Remove use of scala jar twitter util-core with java futures in S3A
> prefetching stream
> -------------------------------------------------------------------------------------
>
> Key: HADOOP-18180
> URL: https://issues.apache.org/jira/browse/HADOOP-18180
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/s3
> Affects Versions: 3.4.0
> Reporter: PJ Fanning
> Assignee: PJ Fanning
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> This jar will cause trouble for scala projects like spark that use different
> scala versions from the scala 2.11 used in the twitter util-core
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
