slfan1989 opened a new pull request, #4274: URL: https://github.com/apache/hadoop/pull/4274
### Description of PR In [YARN-10465](https://issues.apache.org/jira/browse/YARN-10465), some methods have been implemented, from a personal point of view, some doubts. Question 1: Without considering the metric implementation, it is impossible to understand the execution of related functions. Question 2: Using multi-threading and reflection implementation, the readability of the related logic is relatively poor, and there is not much performance difference between this method and the conventional loop method to obtain the theory. Question 3: The code is already 2 years old, merged into the local branch, there may be conflicts. ### How was this patch tested? Added Junit Test to test normal requests and NULL requests, all as expected ### For code changes: 1.Use the loop method to call the getClusterNodes method of the subcluster one by one 2.Complete the Metric indicator counting function 3.Adapt to branch2.10 & branch3.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
