steveloughran commented on PR #3289:
URL: https://github.com/apache/hadoop/pull/3289#issuecomment-1098045775
```
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/CommitContext.java:348:
private class PoolSubmitter implements TaskPool.Submitter, Closeable {: Class
PoolSubmitter should be declared as final. [FinalClass]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/PersistentCommitData.java:105:
return serializer.load(fs, path,status);:36: ',' is not followed by
whitespace. [WhitespaceAfter]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/CreateFileBuilder.java:22:import
java.util.Collections;:8: Unused import - java.util.Collections.
[UnusedImports]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/impl/MkdirOperation.java:190:
void createFakeDirectory(final Path dir) throws IOException;:30: Redundant
'final' modifier. [RedundantModifier]
./hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/WriteOperationHelper.java:326:
* {@link S3AFileSystem#finishedWrite(String, long, String, String,
org.apache.hadoop.fs.s3a.impl.PutObjectOptions)}: Line is longer than 100
characters (found 118). [LineLength]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperationCost.java:256:
commitOperations.commitOrFail(singleCommit);: 'block' child has
incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperationCost.java:257:
IOStatistics st = commitOperations.getIOStatistics();: 'block' child
has incorrect indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/commit/ITestCommitOperationCost.java:258:
return ioStatisticsToPrettyString(st);: 'block' child has incorrect
indentation level 10, expected level should be 6. [Indentation]
./hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/performance/ITestS3ADeleteCost.java:284:
);: 'method call rparen' has incorrect indentation level 8, expected
level should be 4. [Indentation]
Code | Warning
-- | --
IS | Inconsistent synchronization of
org.apache.hadoop.fs.s3a.commit.CommitContext.outerSubmitter; locked 60% of time
| Bug type IS2_INCONSISTENT_SYNC (click for details)In class
org.apache.hadoop.fs.s3a.commit.CommitContextField
org.apache.hadoop.fs.s3a.commit.CommitContext.outerSubmitterSynchronized 60% of
the timeUnsynchronized access at CommitContext.java:[line 291]Unsynchronized
access at CommitContext.java:[line 170]Synchronized access at
CommitContext.java:[line 332]Synchronized access at CommitContext.java:[line
330]Synchronized access at CommitContext.java:[line 332]
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/AbstractS3ACommitter.java:1442:
warning: no @throws for java.io.IOException
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/MagicCommitIntegration.java:94:
warning: no @param for trackerStatistics
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/files/PersistentCommitData.java:121:
warning: no @param for path
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/commit/magic/MagicCommitTracker.java:80:
warning: no @param for trackerStatistics
Code Warning
IS Inconsistent synchronization of
org.apache.hadoop.fs.s3a.commit.CommitContext.outerSubmitter; locked 60% of time
[Bug type IS2_INCONSISTENT_SYNC (click for
details)](https://ci-hadoop.apache.org/job/hadoop-multibranch/job/PR-3289/11/artifact/out/new-spotbugs-hadoop-tools_hadoop-aws.html#IS2_INCONSISTENT_SYNC)
In class org.apache.hadoop.fs.s3a.commit.CommitContext
Field org.apache.hadoop.fs.s3a.commit.CommitContext.outerSubmitter
Synchronized 60% of the time
Unsynchronized access at CommitContext.java:[line 291]
Unsynchronized access at CommitContext.java:[line 170]
Synchronized access at CommitContext.java:[line 332]
Synchronized access at CommitContext.java:[line 330]
Synchronized access at CommitContext.java:[line 332]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
