szilard-nemeth commented on pull request #4117: URL: https://github.com/apache/hadoop/pull/4117#issuecomment-1085891190
Seems like the following Spotbugs warnings are not valid anymore as I fixed them with the commit 04200161ceb. However, somehow Spotbugs still shows them as warnings which I don't really get. Also, I installed Spotbugs in my IntelliJ IDEA and it doesn't report the warning on my local machine. The warnings: ``` 1. org.apache.hadoop.yarn.sls.AMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into AMRunner.inputTraces 2. Write to static field org.apache.hadoop.yarn.sls.AMRunner.remainingApps from instance method org.apache.hadoop.yarn.sls.AMRunner.startAM() ``` The other warning will be fixed with the commit I created just now: `org.apache.hadoop.yarn.sls.NMRunner.setInputTraces(String[]) may expose internal representation by storing an externally mutable object into NMRunner.inputTraces` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
