steveloughran commented on a change in pull request #2971:
URL: https://github.com/apache/hadoop/pull/2971#discussion_r826837442
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>test</scope>
Review comment:
this does mean that abfs-test jar does need it on the classpath.
if i declare this as provided, that will not be the case.
but it will then be a compile time dependency of the production code
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
Review comment:
scope "provided" means used to compile but not included in the
dependency list of the published artifact
*there are no new runtime dependencies unless you want to use the manifest
committer*
##########
File path: hadoop-tools/hadoop-azure/pom.xml
##########
@@ -219,6 +219,58 @@
<scope>test</scope>
</dependency>
+ <!--
+ the mapreduce-client-core module is compiled against for the
+ manifest committer support. It is not needed on the classpath
+ except when using this committer, so it only tagged as
+ "provided".
+ -->
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>provided</scope>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-mapreduce-client-core</artifactId>
+ <scope>test</scope>
+ <type>test-jar</type>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
Review comment:
scope is test only. we have lots of other test scope only dependencies
already and it is not an issue
note also the hadoop-azure-test jar will not publish any of its transitive
dependencies at all. so nobody will notice. which is good as we already pull in
things like distcp
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
