zhongjingxiong commented on a change in pull request #4036:
URL: https://github.com/apache/hadoop/pull/4036#discussion_r816435439
##########
File path:
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestFileUtil.java
##########
@@ -726,7 +727,10 @@ public void testUnZip() throws IOException {
// check result:
assertTrue(new File(tmp, "foo").exists());
assertEquals(12, new File(tmp, "foo").length());
-
+ assertTrue(new File(tmp, "foo").canExecute());
+ assertTrue(new File(tmp, "foo").canRead());
+ assertTrue(new File(tmp, "foo").canWrite());
Review comment:
1.This is a good test scenario, but windows system does not have the
permission information of group/other IIRC.
2.If it is a Windows operating platform, it will skip the permission logic,
because the Windows system itself does not have detailed executable permission,
only read and write permission,the method of canExecute defaults to true on
Windows systems.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
