[
https://issues.apache.org/jira/browse/HADOOP-18029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17459512#comment-17459512
]
Desmond Sisson commented on HADOOP-18029:
-----------------------------------------
I am also new to open source contribution; in this case the ability to handle
uppercase extensions was more of a bug than an improvement, as it looked like
it was handled implicitly in other parts of the class. While I think the file
input specification in HADOOP-17562 would be useful, I would run it by a
contributor to understand if it would break any existing behaviour.
> Update CompressionCodecFactory to handle uppercase file extensions
> ------------------------------------------------------------------
>
> Key: HADOOP-18029
> URL: https://issues.apache.org/jira/browse/HADOOP-18029
> Project: Hadoop Common
> Issue Type: Improvement
> Components: common, io, test
> Environment: Tested locally on macOS 11.6.1, IntelliJ IDEA 2021.2.3,
> running maven commands through terminal. Forked from trunk branch on November
> 29th, 2021.
> Reporter: Desmond Sisson
> Assignee: Desmond Sisson
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> I've updated the CompressionCodecFactory to be able to handle filenames with
> capitalized compression extensions. Two of the three maps internal to the
> class which are used to store codecs have existing lowercase casts, but it is
> absent from the call inside getCodec() used for comparing path names.
> I updated the corresponding unit test in TestCodecFactory to include intended
> use cases, and confirmed the test passes with the change. I also updated the
> error message in the case of a null from an NPE to a rich error message. I've
> resolved all checkstyle violations within the changed files.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
