functioner commented on pull request #3719: URL: https://github.com/apache/hadoop/pull/3719#issuecomment-986142771
@virajjasani Thank you for pointing out the checkstyle issue. I've pushed a new commit to resolve it. To minimize the checkstyle modification, I move the `configureSocketChannel` method from `Server$Listener` to `Server`, so that we can solely override this method to enable the unit test. `Server$Listener` remains `private`. I also add the `@VisibleForTesting` and `@InterfaceAudience.Private` annotations. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
