[
https://issues.apache.org/jira/browse/HADOOP-17995?focusedWorklogId=683941&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-683941
]
ASF GitHub Bot logged work on HADOOP-17995:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/21 13:51
Start Date: 19/Nov/21 13:51
Worklog Time Spent: 10m
Work Description: sodonnel commented on pull request #3630:
URL: https://github.com/apache/hadoop/pull/3630#issuecomment-974089664
This change has introduced a findbugs warning on trunk, which was in the
build above:
```
<a name="Warnings_MT_CORRECTNESS">Multithreaded correctness Warnings</a>
code | Warning
-- | --
IS | Inconsistent synchronization of
org.apache.hadoop.metrics2.lib.MutableRollingAverages.recordValidityMs; locked
66% of time
```
I wonder if the snapshot method needs synchronised to avoid this? We cannot
make `recordValidityMs` final is it can be changed by the tests, but we need to
fix it somehow to clear the spotbugs warning which is now present in all PRs
since this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 683941)
Time Spent: 2h 10m (was: 2h)
> Stale record should be remove when
> DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson
> --------------------------------------------------------------------------------------------
>
> Key: HADOOP-17995
> URL: https://issues.apache.org/jira/browse/HADOOP-17995
> Project: Hadoop Common
> Issue Type: Bug
> Reporter: Haiyang Hu
> Assignee: Haiyang Hu
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> As [HADOOP-16947|https://issues.apache.org/jira/browse/HADOOP-16947] problem
> with description,
> Stale SumAndCount also should be remove when
> DataNodePeerMetrics#dumpSendPacketDownstreamAvgInfoAsJson.
> Ensure the DataNode JMX get SendPacketDownstreamAvgInfo Metrics is accurate
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
