ayushtkn commented on a change in pull request #3455:
URL: https://github.com/apache/hadoop/pull/3455#discussion_r711520715
##########
File path:
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestStorageRestore.java
##########
@@ -294,7 +294,7 @@ public void testDfsAdminCmd() throws Exception {
restore = fsi.getStorage().getRestoreFailedStorage();
assertTrue("After check call restore is " + restore, restore);
String commandOutput = cmdResult.getCommandOutput();
- commandOutput.trim();
+ commandOutput = commandOutput.trim();
assertTrue(commandOutput.contains("restoreFailedStorage is set to
true"));
Review comment:
I think we can remove ``commandOutput.trim();`` itself. The
``assertTrue`` is anyway checking ``contains`` which will pass irrespective of
this ``trim``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
