virajjasani commented on a change in pull request #3429:
URL: https://github.com/apache/hadoop/pull/3429#discussion_r711264932



##########
File path: 
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/mover/TestMover.java
##########
@@ -872,7 +872,6 @@ void initConfWithStripe(Configuration conf) {
   public void testMoverWithStripedFile() throws Exception {
     final Configuration conf = new HdfsConfiguration();
     initConfWithStripe(conf);
-

Review comment:
       > Not strongly opposed but not ideal.
   
   I agree with your review, addressed in the latest commit. No change in 
logic, just the refactor as you have suggested.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to