snvijaya commented on pull request #3381: URL: https://github.com/apache/hadoop/pull/3381#issuecomment-918198704
> LGTM; some minor changes. Main one is using/adding a statistic to StreamStatisticNames Hi @steveloughran , Thanks for taking the time to review this PR. Post analyzing the metric gathering spot and the metric grouping in StreamStatistics and StoreStatistics, I feel the new statistics is probably right to be defined within AbfsStatistics. Have added my explanation for this above. Kindly request your inputs on this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
