ayushtkn commented on pull request #3387: URL: https://github.com/apache/hadoop/pull/3387#issuecomment-917454461
> if we want to change import order for thirdparty shaded guava, I believe we can first do it on checkstyle.xml and then update formatter accordingly. WDYT? I think we can change here as well, and then change it in the checkstyle.xml. @steveloughran IIRC, you told me somewhere that we keep the shaded guava imports like this? Is it ok if we change the formatter & checkstyle to adapt to that? @virajjasani Can you share me the link to the ML discussion? Do drop a message there, if in case anyone has any further suggestion/comments. We can wait for a couple of days after that, and check this in, If everyone is happy -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
