szilard-nemeth commented on a change in pull request #3259:
URL: https://github.com/apache/hadoop/pull/3259#discussion_r684253185
##########
File path:
hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-shuffle/src/test/java/org/apache/hadoop/mapred/TestShuffleHandler.java
##########
@@ -204,6 +828,34 @@ protected boolean isSocketKeepAlive() {
}
}
+ @Rule
+ public TestName name = new TestName();
+
+ @Before
+ public void setup() {
+ TEST_EXECUTION = new TestExecution(DEBUG_MODE, USE_PROXY);
+ }
+
+ @After
+ public void tearDown() {
+ int port = TEST_EXECUTION.shuffleHandlerPort();
+ if (isPortUsed(port)) {
+ String msg = String.format("Port is being used: %d. " +
+ "Current testcase name: %s",
+ port, name.getMethodName());
+ throw new IllegalStateException(msg);
+ }
+ }
+
+ private static boolean isPortUsed(int port) {
+ try (Socket ignored = new Socket("localhost", port)) {
+ return true;
+ } catch (IOException e) {
+ LOG.error("Port: {}, port check result: {}", port, e.getMessage());
+ return false;
+ }
+ }
+
Review comment:
Good point, added explicit check for port=0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
